Optimize normal-fit neighborhood sampling in vc_ngrids#725
Open
giorgioangel wants to merge 1 commit intomainfrom
Open
Optimize normal-fit neighborhood sampling in vc_ngrids#725giorgioangel wants to merge 1 commit intomainfrom
giorgioangel wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ngv.query_nearest(...)lookups and avoid rebuilding sample vectors for each radius step to cut CPU overhead when fitting normals.Description
(plane_idx, slice_idx)forngv.query_nearest(...)results and aquery_nearest_cached(...)helper to reuse resolved grids across radius steps and nearby samples.SegmentCandidateto store per-segment metadata (dir_unit,delta_xyz,weight,dist2,is_short_path) and addgather_segment_candidates(...)that collects and sorts all candidates once for the maximum radius.gather_samples_for_radius(...)advances per-plane cursors through the distance-sorted candidate lists and appends only newly in-range segments for larger radii, rather than rebuilding vectors from scratch.FitBuffersto persistcandidatesand per-planecandidate_cursorso candidate lists and cursors survive across radius iterations inside a sample evaluation.dirs_unit,weights, anddeltas_xyzinputs after the refactor).Testing
cmake -S volume-cartographer -B volume-cartographer/build -DCMAKE_BUILD_TYPE=Release, but the build configuration failed because dependency fetches from GitHub were blocked (CONNECT tunnel failed, response 403forxtl.git), so a full compile/run verification could not be completed.Codex Task